Add repo_id for attachment #16958
Merged
Add repo_id for attachment #16958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
reviewed
Sep 5, 2021
GiteaBot
added
the
lgtm/need 2
6543
reviewed
Sep 5, 2021
6543
reviewed
Sep 5, 2021
6543
reviewed
Sep 5, 2021
6543
added
the
type/refactoring
…into lunny/add_attachment_repoid
6543
reviewed
Sep 5, 2021
6543
reviewed
Sep 5, 2021
6543
reviewed
Sep 5, 2021
6543
reviewed
Sep 5, 2021
6543
approved these changes
Sep 5, 2021
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #16958 +/- ##
=======================================
Coverage ? 45.18%
=======================================
Files ? 763
Lines ? 86208
Branches ? 0
=======================================
Hits ? 38952
Misses ? 40955
Partials ? 6301
Continue to review full report at Codecov.
|
axifive
approved these changes
Sep 8, 2021
GiteaBot
added
lgtm/done
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When create a new issue or comment and paste/upload an attachment/image, it will not assign an issue id before submit. So if user give up the creating, the attachments will lost key feature and become dirty content. We don't know if we need to delete the attachment even if the repository deleted.
This PR add a repo_id in attachment table so that even if a new upload attachment with no issue_id or release_id but should have repo_id. When deleting a repository, they could also be deleted.